Skip to content

Fix locations for intrinsics impls and change to links #96228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 21, 2022
Merged

Fix locations for intrinsics impls and change to links #96228

merged 2 commits into from
Apr 21, 2022

Conversation

mbartlett21
Copy link
Contributor

These still referred to rustc_mir.

@rust-highfive
Copy link
Contributor

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with r? rust-lang/libs-api @rustbot label +T-libs-api -T-libs to request review from a libs-api team reviewer. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Apr 19, 2022
@rust-highfive
Copy link
Contributor

r? @thomcc

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 19, 2022
@thomcc
Copy link
Member

thomcc commented Apr 20, 2022

I don't know what these paths are. I'll reroll for you but feel free to request a specific reviewer who knows where these are.

r? rust-lang/libs

@rust-highfive rust-highfive assigned joshtriplett and unassigned thomcc Apr 20, 2022
@mbartlett21
Copy link
Contributor Author

@thomcc / @joshtriplett They are just from the root of this repo. Should I change them to be a link to Github, like the one referring to miri (line 12)?

@thomcc
Copy link
Member

thomcc commented Apr 20, 2022

A link would be better, as it could also detect breakage using rustdoc's link checker.

@thomcc
Copy link
Member

thomcc commented Apr 20, 2022

Okay. This is fine. Sorry for the trouble (both to you and to @joshtriplett). I thought I was missing context for this change, but I wasn't. That said, I think the link should hold up slightly better.

@bors r+

@bors
Copy link
Collaborator

bors commented Apr 20, 2022

📌 Commit 4879875 has been approved by thomcc

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 20, 2022
@mbartlett21 mbartlett21 changed the title Fix locations for intrinsics impls Fix locations for intrinsics impls and change to links Apr 20, 2022
@mbartlett21
Copy link
Contributor Author

@thomcc
That's fine ;)

@Dylan-DPC Dylan-DPC mentioned this pull request Apr 20, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 21, 2022
@bors
Auto merge of rust-lang#96263 - Dylan-DPC:rollup-0eofl13, r=Dylan-DPC
7be1da0 
Rollup of 5 pull requests

Successful merges:

 - rust-lang#90630 (Create real parser for search queries)
 - rust-lang#96193 ([fuchsia] Add implementation for `current_exe`)
 - rust-lang#96196 (Remove assertion that all paths in `ShouldRun` exist)
 - rust-lang#96228 (Fix locations for intrinsics impls and change to links)
 - rust-lang#96236 (Add an explicit `Span` field to `OutlivesConstraint`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit e2543d7 into rust-lang:master Apr 21, 2022
@rustbot rustbot added this to the 1.62.0 milestone Apr 21, 2022
@mbartlett21 mbartlett21 deleted the patch-4 branch April 24, 2022 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@joshtriplett joshtriplett

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.62.0
Development

Successfully merging this pull request may close these issues.
6 participants
@mbartlett21 @rust-highfive @thomcc @bors @joshtriplett @rustbot